search

DonDebonair / pelican-bootstrap3

Bootstrap 3 theme for Pelican
330 stars 259 forks source link

Translation infrastructure and German translation #246

Closed jranke closed 8 years ago

jranke commented 8 years ago

Includes a Makefile for conveniently calling pybabel.

Based on https://github.com/getpelican/pelican-plugins/blob/master/i18n_subsites/localizing_using_jinja2.rst

Note that if this PR is accepted, all users need to add

JINJA_EXTENSIONS = ['jinja2.ext.i18n']

to their pelican configuration as amended in the README.

DirkR commented 8 years ago

Great, I have the same task in my todo list. Now it's almost done. :)

Maybe one could add/inject the JINJA_EXTENSIONS = ['jinja2.ext.i18n'] when bootstrapping the build process? I just didn't check the api docs...

jranke commented 8 years ago

@DirkR: Maybe you can have a look and check my implementation? For example, I did not use any pluralizing, and I skipped series and related posts as I do not currently use them.

No idea how or if the Jinja extension could be injected, but it would be very helpful if people pulling from master would not be left with a broken setup!

DirkR commented 8 years ago

@jranke I will test it (and add support for series and related posts) as soon as I'm playing with my website project the next time. Hope to get this translation effort working soon!

jranke commented 8 years ago

@DirkR: Great! Looking forward to that.

Just to make clear - my i18n branch does work, anyone that wants to have a look, see http://jrwb.de and http://jrwb.de/de. I know, I need language buttons...

DirkR commented 8 years ago

@jranke Thats how I understood it. ;)

jranke commented 8 years ago

Yes, the interesting question is can/will it be integrated in the master branch...

cranmer commented 8 years ago

@DandyDev is it possible to give some update on status / time for development of the theme. We had some discussion about that earlier, but I'm a little confused about the current status.

DonDebonair commented 8 years ago

@cranmer Sorry for the lack of updates. I've had a busy schedule with work of the past half year and some health related issues. The plan is to pick up pelican-bootstrap3 related work next week!

cranmer commented 8 years ago

Sounds great, I hope you are feeling better.

DonDebonair commented 8 years ago

Hi!

First of all, thanks for your pull request! I appreciate the contribution, but I cannot accept this PR at the moment. It's with heavy heart that I have decided that I can no longer maintain this theme due to lack of time and changing interests. To makes sure the theme lives on however and not goes to waste, I've donated it to the Pelican community. It can now be found in the official pelican-themes repository. I'd suggest you re-submit your pull request there.

Sorry for the inconvenience!