search

DonDebonair / slack-machine

A simple, yet powerful and extendable Slack bot
https://dondebonair.github.io/slack-machine/
MIT License
757 stars 54 forks source link

add rate limiting for channel and user fetch #1115

Open sprutner opened 3 weeks ago

sprutner commented 3 weeks ago

Yeah I tested it on my workspace with like 68,000 users. It boots but it isn't respond to me when I DM or mention it..perhaps workspace permissions issue. I resubmitted the app to our workspace. I pushed a couple commits but haven't tested it. I never set the python env up it was just a late night hack. I can look more into cleaning this up over the weekend :)

DonDebonair commented 3 weeks ago

Yeah it would help if you can do a bit of serious testing :)

sprutner commented 3 weeks ago

@DonDebonair doesn't seem like your tests run on each commit. It is hard for me to see if it's passing your tests here but re-requesting review. Installed the pre-commit hooks and ran them and got them to pass.

DonDebonair commented 3 weeks ago

Can you allow me to push to this branch on your fork? It's probably easier for me to fix the MyPy issues and I want to rebase the branch on main as well

sprutner commented 3 weeks ago

@DonDebonair done

DonDebonair commented 3 weeks ago

You let Dependabot update your branch, but those updates are also present on the main branch. This is causing conflicts when trying to rebase.

Can you fix your branch or open a new PR from the main branch (which is now fully up to date)

DonDebonair commented 1 week ago

@sprutner can you recreate the PR based on the latest main branch?