search

DonJayamanne / javaVSCode

Extension for java development on VSCode (deprecated)
https://marketplace.visualstudio.com/items?itemName=donjayamanne.javaDebugger
MIT License
43 stars 29 forks source link

Allow to attach to multithreaded processes #56

Closed dueckminor closed 7 years ago

dueckminor commented 7 years ago

As you wrote in your README.md Debugging of Multie Threaded apps is possible but very flaky. The debugger could at times hang.

I'm pretty sure that I found the reason for this and I also was able to fix it.

Especially in multi threaded processes it happens often that no thread is selected. In this case you will get the following prompt: '>' But in jdb.ts, a prompt like this is expected: 'main[1]'

This fix, checks also for '> ', which makes it possible to attach to multithreaded processes.

faustinoaq commented 7 years ago

Let me test this PR before merge.

Thanks you! :smile:

dueckminor commented 7 years ago

Good idea.

faustinoaq commented 7 years ago

This PR works as expected