Add 'Scroll to bottom' feature

DonJayamanne / vscodeJupyter

Jupyter for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=donjayamanne.jupyter

MIT License

334 stars 34 forks source link

Add 'Scroll to bottom' feature #97

Closed garaemon closed 6 years ago

garaemon commented 6 years ago

Scroll to the bottom when appending the results of jupyter to results tab
Add checkbox to toggle 'Scroll to bottom'
Add 'jupyter.scrollToBottom' config

vscode-emacs

gandhis1 commented 6 years ago

In my opinion, this shouldn't be optional - this should be the default setting. I and maybe others created an issue on this.

DonJayamanne commented 6 years ago

I agree. Will review and merge

DonJayamanne commented 6 years ago

@garaemon Apologies for the delay in getting back to you on this I'd like to merge this PR. Please could you:

Make this the default behavior instead of a flag (i.e. remove the flag)
Please could you fix the merge conflicts as well.

Thanks, would like to merge this PR for a new release for this week. Once again, thanks for the great PR

garaemon commented 6 years ago

Sorry for late reply

Make this the default behavior instead of a flag (i.e. remove the flag) Please could you fix the merge conflicts as well.

Done and there is only 1 line diff :)

dakl commented 6 years ago

@DonJayamanne When can we expect this to be released on marketplace?

Thanks!

Louis-udm commented 6 years ago

@DonJayamanne When can we expect this to be released on marketplace? It’s been a long time.

Thanks!

yzhang-gh commented 5 years ago

Same request here, could you please publish a new version to the marketplace?

~~I tried to package it by myself but failed because I know little about webpack and react 😥~~

yzhang-gh commented 5 years ago

Finally figured it out. ~~jupyter-1.1.4-be71800.zip~~

Edit: Published to marketplace (Jupyter)

Louis-udm commented 5 years ago

Great!!! Thanks a lot! @neilsustc

I tried and failed!

dsanalytics commented 5 years ago

@neilsustc where do we drop this file in or do we import this vsix somehow? Can somebody shed some light here? Thank you.

P.S. Which software did you use to create that animation? Is that SnagIt?

yzhang-gh commented 5 years ago

Install from a VSIX and ScreenToGif

dsanalytics commented 5 years ago

FYI: Command line import of @neilsustc vsix did not work for me - no errors on import, but no auto scroll either. Perhaps I could be doing something wrong. Also, would re-importing of this extension (assuming working) be required every time VS Code updates itself?

P.S. VS Code v1.27.2 (Win7 64bit Home Prem)

yzhang-gh commented 5 years ago

And then reload vscode.

No re-installation is required unless DonJayamanne publish a new version.

dsanalytics commented 5 years ago

@neilsustc worked - thx!

Louis-udm commented 5 years ago

it work! I said I tried to package it also by myself, but failed. Thanks @neilsustc