search

DonaldHays / rgbds-vscode

Visual Studio Code language extension for RGBDS GBZ80 Assembly
MIT License
65 stars 9 forks source link

add keywords: fragment, incbin, load #9

Closed jendrikw closed 4 years ago

jendrikw commented 4 years ago

This keyword was added in rgbds 0.4.1 see https://github.com/gbdev/rgbds/issues/517

DonaldHays commented 4 years ago

I'm feeling kind of guilty that it takes changes to five places to add a new keyword 😬.

I'm scanning the RGBDS changelog, and it looks like a new feature called load blocks were added since I last updated the extension, and so I think load is a new preprocessor keyword.

I'm also seeing incbin, which has possibly been supported by RGBDS all this time, but I neglected to add its keyword.

@jendrikw if you wanted, you could add those keywords to this PR, or I could add them after I merge this. Do you have plans for any other pull requests before it would be appropriate for me to cut a new release of the extension? Thanks!

jendrikw commented 4 years ago

I'm opening PRs as I come across things that don't work as I expected, so I can't tell if there's more to come.

Rangi42 commented 4 years ago

The load keyword is paired with endl. Some others: newcharmap, setcharmap. There's also the function keyword isconst.

DonaldHays commented 4 years ago

646fba9dae8b7c31505027b0197dca44c4afaab9 859b2f34b77d67f1c17ccf0ed1b914c7cfaa80ad 305a668bf2f7b22a8abf3e456b1c3dcc1a9f49c5 f92edd95d53ec9f20646771c82e8dfe5375bfd5a

Thanks!