Donaldcwl / browser-image-compression

Image compression in web browser

MIT License

1.3k stars 160 forks source link

Multiple compatibility issues with cordova-plugin-file #11

Closed arivera-skycred closed 5 years ago

arivera-skycred commented 5 years ago

First, thank you for the plugin. It's been working great so far until we added cordova-plugin-file to our solution.

It appears that the new types for File and FileReader don't work with this plugin.

I am working on fixes that will be backwards compatible with non-cordova implementations and will submit a PR when I have it working.

Cheers!

Donaldcwl commented 5 years ago

12 PR merged, I will release a new version soon. Thanks.

Donaldcwl commented 5 years ago

@arivera-skycred I have made some modifications so that the tests will pass. I may need your help to test it with your cordova environment, please refer to #12. Thanks.

arivera-skycred commented 5 years ago

@arivera-skycred I have made some modifications so that the tests will pass. I may need your help to test it with your cordova environment, please refer to #12. Thanks.

Sure thing. I'll take a look.