DonattKrasniqii / Laravel-Task-Manager

0 stars 0 forks source link

Search with filters selected to "ALL" doesn't show any results (Tasks) #1

Open haris-im opened 9 hours ago

haris-im commented 9 hours ago

Hiii, I tottttttally didn't look through the code to find something just to say hi!

Also extra suggestion (I'm sure you knew this but incase you didn't)

ProfileController.php

public function update(ProfileUpdateRequest $request): RedirectResponse
  {
      $request->user()->fill($request->validated());

      if ($request->user()->isDirty('email')) {
          $request->user()->email_verified_at = null;
      }

      $request->user()->save();

      return Redirect::route('profile.edit')->with('status', 'profile-updated');
  }

Would be nice to actually use specific values which you wish to update incase you ever add new fillable's that shouldn't be touched by users manually. You can add any input in the form (manually through inspect element) and submit and since you're using fill($request->validated()); will just fill anything in the database. In this case it isn't an issue since everything that's fillable is also on the form.

haris-im commented 9 hours ago

(Delete after lol)