Donders-Institute / PRESTUS

PREprocessing & Simulations for Transcranial Ultrasound Stimulation package
GNU General Public License v3.0
12 stars 10 forks source link

Figure saving updates, some bug fixes #8

Closed jkosciessa closed 8 months ago

jkosciessa commented 1 year ago

These commits include various updates I have introduced:

Note: The pipeline ran successfully using my simulation setup scripts and there should be no fundamental constraints on backwards compatibility. But updates have not been tested extensively with different yaml setups.

achetverikov commented 1 year ago

Could anyone else test it on their setup? @KTZ228 , @mekman I think export_fig was used previously to make sure that figures are exported correctly because otherwise there were some issues with multi-layer figures.

mekman commented 9 months ago

Hi @jkosciessa, this branch has already been merged. Could you please commit these changes to a new branch and submit a new pull request? Cheers

mekman commented 8 months ago

Hi @jkosciessa sorry to bother again, I saw that you closed this issue now, but I just want to make sure that the changes won't get lost. Will you submit another PR, or should I do that for you?