Donders-Institute / bidscoin

BIDScoin converts your source-level neuroimaging data to BIDS
https://bidscoin.readthedocs.io
GNU General Public License v3.0
130 stars 35 forks source link

Please clarify GPLv3 licensing #190

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 1 year ago

Describe the bug

While the trove classifiers in pyproject.toml and the LICENSE.txt file in bidscoin indicate the project can be used under the GPLv3, there is no license notice as recommended in https://www.gnu.org/licenses/gpl-howto.html.

A consequence of this is that it is not entirely clear whether the precise intended license is, in SPDX terms, GPL-3.0-only or GPL-3.0-or-later. (A conservative assumption would be the former.)

To reproduce Steps to reproduce the behavior:

  1. Search the repository for a license notice.

Expected behavior The exact license terms are clear. Ideally, a license notice of the form recommended by GNU is present.

Software version

Additional context

marcelzwiers commented 1 year ago

I added a new license description in the README and an SPDX identifier in the main __ini__ file (I think adding it to every file is cumbersome and not really needed). Do you think this is enough or is there more I could do?

musicinmybrain commented 1 year ago

I added a new license description in the README and an SPDX identifier in the main __ini__ file (I think adding it to every file is cumbersome and not really needed). Do you think this is enough or is there more I could do?

Thanks! Speaking only as a Fedora Linux packager, this is helpful and should be sufficient to establish the correct license and pass package review for the distribution. (There are some dependencies we need to package up first.)

Whether or not it would be legally or practically helpful to you or to some users to have a copyright and license notice of the form recommended by GNU somewhere in the source is somewhat beyond me.

marcelzwiers commented 1 year ago

Ok, I'll consider it good enough, thank you for your feedback!