search

DonkeyKongJr / pimlify

A vue (pwa) to take orders for our most favorite restaurant. All data is stored in firebase.
MIT License
1 stars 0 forks source link

CD: Firebase Deployment #39

Closed DonkeyKongJr closed 6 years ago

DonkeyKongJr commented 6 years ago

Is your feature request related to a problem? Please describe. Add automatic firebase deployment to travis ci when execution a build on the master branch.

DonkeyKongJr commented 6 years ago

@Opiskull how do we provide the firebase configuration? Pushing it to the repository or are there any better alternatives?

Opiskull commented 6 years ago

hm... no idea... are there conventions somewhere? how are other people doing it?

DonkeyKongJr commented 6 years ago

There seems to be no correct answer, however as we know every client needs to know the firebase config to connect to the services and they are exposed anyways. Since we allow only calls to our ressources from authenticated users it seems to be fine to put the config in the repository.

https://stackoverflow.com/questions/37482366/is-it-safe-to-expose-firebase-apikey-to-the-public

DonkeyKongJr commented 6 years ago

Config was added in #45 from @Opiskull ^^

DonkeyKongJr commented 6 years ago

Fixed with fixing build config by adding index.html