search

DonkeyRepublic / lockkit-android

Donkey Lock Kit for Android
https://developer.donkey.bike/tomp/lockkit/docs/android/
3 stars 0 forks source link

Bluetooth_le might not be required for apps implementing the SDK #4

Closed PatrickKuijpers closed 2 years ago

PatrickKuijpers commented 2 years ago

When releasing (updating) the app with your SDK added, we noticed that several devices were not able to download our app anymore. The Lockkot SDK defines the bluetooth_le feature as required in the AndroidManifest. This prevent many devices from installing the app in the Play Store. I understand it is required by the SDK, but might not be required by the apps using the SDK (optional feature).

Defining it as required in the SDK might be the correct choice, but this effect might be easily overlooked or forgotten by developers using your SDK, especially when it would involve a first production release.

It might help other developers to document this, probably the ReadMe:

    <uses-feature
        android:name="android.hardware.bluetooth_le"
        android:required="false"
        tools:replace="android:required" />
PatrickKuijpers commented 2 years ago

Thanks for the readme clarification!