search

Donkie / I3DShapesTool

Tool used for extracting the binary .i3d.shapes files used by the GIANTS engine
MIT License
24 stars 10 forks source link

Master #8

Closed VirRus77 closed 4 years ago

VirRus77 commented 4 years ago

Little refactoring. Translation of logging to basic logging through Microsoft.Extensions.Logging.Abstractions. Highlighting a library with basic functionality.

VirRus77 commented 4 years ago

The main commentary to the source: the reduction of characters. When you are alone on a project, yes. If not, don't cut it =)

Donkie commented 4 years ago

Closing this because #9 contains this commit as well.

Donkie commented 4 years ago

actually nvm i'll just merge this first

VirRus77 commented 4 years ago

The I3Decriptor carries a logical rationale: in one part, working with the key itself, in the other, working with the data key. Accordingly, the Load method in ShapesFile is left temporarily. In the future, it will be deleted and will need to work only with Entity. Because only this feature allows you to download information from maps using small memory. How I use: https://github.com/VirRus77/CourseplayEditor/blob/d1547fd2d1ea3c95a59c92cc60a469e1610bb33a/CourseplayEditor/ViewModel/MainWindowViewModel.cs#L162