Donkie / Spoolman

Keep track of your inventory of 3D-printer filament spools.
MIT License
891 stars 82 forks source link

QR Code scanning add button with a supported data for a db entry embedded in the QR code. #66

Open NonaSuomy opened 1 year ago

NonaSuomy commented 1 year ago

OP Ref: https://github.com/Donkie/Spoolman/issues/10

I haven't tested if you can already do this with the edit button or not. Could you add an add button to the scan page where you can click add for a QR code that is not in your database? Which it will then fill in all the values for you from whatever the manufacturer sets. Say the producers of the filament wanted to support Spoolman and had premade Spoolman QR codes on their spools for instance that you just bought or a friend/reseller sent you a spool with the Spoolman QR tag on it.

Can you add another action button on the spool list that sets the spool id via a call to Moonraker?

Moved to: https://github.com/Donkie/Spoolman/issues/72

Donkie commented 1 year ago

The current QR codes contains no data other than the spool ID. To do what you ask, it would have to be extended to support that, which could be done I guess, but is not what I had in mind from the beginning.

Spoolman has no knowledge of Moonraker's existence, which is how I want it to remain. The embedded client in Spoolman was never intended to be the main interface for Spoolman. The intention was always that the frontends (Mainsail etc) would do the actual client. They know about Moonraker, and can thus easily set the spool and so on.

NonaSuomy commented 1 year ago

The current QR codes contains no data other than the spool ID. To do what you ask, it would have to be extended to support that, which could be done I guess, but is not what I had in mind from the beginning.

Makes sense. I think this should be extended to enable this before things get too popular. Would make spool entry leaps and bounds easier to catalog.

I'm going to change the title to only this for a feature request then move the second part to another one.

Moved second question to: https://github.com/Donkie/Spoolman/issues/72

Thank you.