search

Donkie / SpoolmanDB

A centralized place to store information about 3D printing filaments and their manufacturers
MIT License
30 stars 19 forks source link

Added my current used filaments from my spoolman instance #1

Closed Disane87 closed 4 months ago

Disane87 commented 4 months ago

Added my current used filaments from my spoolman instance

Disane87 commented 4 months ago

@Donkie I have created a python script which gathers the filaments from the API. Do you mind when I add this to the repo? Or you can add this as a submodule and reference the script repo: https://github.com/Disane87/Spoolman-filament-extractor

Donkie commented 4 months ago

That's an interesting idea, though I think it's better if people in general grab information from the manufacturer website, since then the info will be more complete. Your script only populates a single weight item for example, while the supplier may well sell multiple sizes.

You may use your script but please ensure the info is complete for each filament you add.

Disane87 commented 4 months ago

That's an interesting idea, though I think it's better if people in general grab information from the manufacturer website, since then the info will be more complete. Your script only populates a single weight item for example, while the supplier may well sell multiple sizes.

Yeah thats one where I'm currently working on. But actually I don't have any other sizes so I haven't done it yet.

You may use your script but please ensure the info is complete for each filament you add.

Yeah sure! Since I add the filaments correctly to spoolman by infos of the manufacturer there should be no problem from my side. The script also uses your schema to validate the json so that obvious errors don't happen.

The script is only inteded to create a base from your spoolman and than add more details (manually) if needed. It's just an POC to get more traction into the process of adding filaments.

Disane87 commented 4 months ago

Sorry I shouldn't have done these changes with that little review from my side. Totally was my fault! Changed the things you've requested

Donkie commented 4 months ago

All good now, thanks for the contribution!