search

Donkie / SpoolmanDB

A centralized place to store information about 3D printing filaments and their manufacturers
MIT License
30 stars 19 forks source link

RFC: Handling different spool weights for the same filament. #5

Closed StuSerious closed 4 months ago

StuSerious commented 4 months ago

Hey there Donkie! It's refreshing to finally see some real effort being put into a centralized database, I have been waiting for this for a long, long time.

I manage a 3D printing research lab and have access to and can contribute hundreds of spools from tens of manufacturers. While working on my first pull request to add Formfutura filaments, I remembered that they sometimes sell different spools for the same filament and weight product. As also seen in their technical spool information, they offer cardboard and plastic variants for the same product, each with different spool weights.

For example, the cardboard 2300g spool weighs ~265g, while the plastic 2300g one weighs ~600g.

I would like to hear opinions and suggestions on how to best handle such cases, as I've seen a steady rise in manufacturers providing cardboard spools as an eco-friendly option.

Thank you so much for all the work you're putting into all this, I look forward to contributing to the best of my ability!

Donkie commented 4 months ago

I have now added an additional field to the weights object where you can specify the type of spool. So in your example you would do:

"weights": [
    {
        "weight": 2300.0,
        "spool_weight": 600,
        "spool_type": "plastic"
    },
    {
        "weight": 2300.0,
        "spool_weight": 265,
        "spool_type": "cardboard"
    }
],
StuSerious commented 4 months ago

Thank you so much! this seems perfect.

I pushed PR https://github.com/Donkie/SpoolmanDB/pull/12 with the filaments in question so you can take a look!