Donkie / tgstation

/tg/'s SS13 branch
http://www.tgstation13.org/
GNU Affero General Public License v3.0
0 stars 0 forks source link

randomized toys crate runtime #9

Closed Donkie closed 4 years ago

Donkie commented 4 years ago

The contains list for /datum/supply_pack/costumes_toys/randomised/toys is empty, yet num_contained is non-zero.

/datum/supply_pack/costumes_toys/randomised/toys/generate is overridden to generate the contents in a special way, but I think fill should be overridden instead

runtime error: Cannot create objects of type null.
 - proc name: fill (/datum/supply_pack/costumes_toys/randomised/fill)
 -   source file: packs.dm,2295
 -   usr: null
 -   src: Toy Crate (/datum/supply_pack/costumes_toys/randomised/toys)
 -   call stack:
 - Toy Crate (/datum/supply_pack/costumes_toys/randomised/toys): fill(the toy crate (/obj/structure/closet/crate/wooden))
 - Toy Crate (/datum/supply_pack/costumes_toys/randomised/toys): generate(null, null)
 - Toy Crate (/datum/supply_pack/costumes_toys/randomised/toys): generate(null)
 - /datum/round_event/stray_cargo (/datum/round_event/stray_cargo): start()
 - /datum/round_event/stray_cargo (/datum/round_event/stray_cargo): process()
 - Events (/datum/controller/subsystem/events): fire(0)
 - Events (/datum/controller/subsystem/events): ignite(0)
 - Master (/datum/controller/master): RunQueue()
 - Master (/datum/controller/master): Loop()
 - Master (/datum/controller/master): StartProcessing(0)