codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 95.65217% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 90.43%. Comparing base (
733a96f) to head (81e2342).
| Files | Patch % | Lines |
|---|---|---|
| src/cf2tf/conversion/expressions.py | 97.29% | 1 Missing :warning: |
| src/cf2tf/convert.py | 88.88% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #278 +/- ## =========================================== + Coverage 89.66% 90.43% +0.77% =========================================== Files 16 16 Lines 1122 1370 +248 Branches 182 262 +80 =========================================== + Hits 1006 1239 +233 - Misses 82 89 +7 - Partials 34 42 +8 ``` | [Flag](https://app.codecov.io/gh/DontShaveTheYak/cf2tf/pull/278/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/DontShaveTheYak/cf2tf/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | `90.43% <95.65%> (+0.77%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The AWS documentation on where functions are allowed to be nested is plain ole wrong. We are contantly finding new combinations from AWS's own templates.
This PR also adds better logging and error handling.