codecov[bot]
commented
4 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.74%. Comparing base (
e22cab6) to head (a84904f). Report is 11 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #293 +/- ## =========================================== - Coverage 89.77% 89.74% -0.04% =========================================== Files 16 16 Lines 1135 1131 -4 Branches 184 182 -2 =========================================== - Hits 1019 1015 -4 Misses 82 82 Partials 34 34 ``` | [Flag](https://app.codecov.io/gh/DontShaveTheYak/cf2tf/pull/293/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/DontShaveTheYak/cf2tf/pull/293/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | `89.74% <100.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This should result in better matches when converting a resource from Cloudformation to Terraform. In my limited local testing I was able to match on more resources correctly while not breaking any of the tricky conversions we already test against.
I also fixed a bug where we were not parsing attributes in the Terraform docs correctly because we only checked for one type of markdown list item, when there is a second valid list item possible. It was discussed in #290