DontShaveTheYak / cf2tf

Convert Cloudformation templates to Terraform.
GNU General Public License v3.0
479 stars 79 forks source link

fix crash when converting tags to Terraform format #294

Closed shadycuz closed 4 months ago

shadycuz commented 4 months ago

In some cases the tags might be a literal condition. This is a bandaid to try and handle that case but it is not a complete solution. Fixes #290

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.13%. Comparing base (e22cab6) to head (a5f76b0). Report is 14 commits behind head on develop.

Files Patch % Lines
src/cf2tf/conversion/overrides.py 50.00% 7 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #294 +/- ## =========================================== - Coverage 89.77% 89.13% -0.65% =========================================== Files 16 16 Lines 1135 1141 +6 Branches 184 183 -1 =========================================== - Hits 1019 1017 -2 - Misses 82 89 +7 - Partials 34 35 +1 ``` | [Flag](https://app.codecov.io/gh/DontShaveTheYak/cf2tf/pull/294/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/DontShaveTheYak/cf2tf/pull/294/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | `89.13% <55.55%> (-0.65%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.