search

DontShaveTheYak / cloud-radar

Create Functional and Unit tests for Cloudformation Stacks.
Apache License 2.0
50 stars 9 forks source link

Correct SSM parameter key regex #317

Closed dhutchison closed 7 months ago

dhutchison commented 7 months ago

Fixes #316 . Updates regex used for validating SSM parameter keys to one that is based on AWS documentation.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c51da0) 95.97% compared to head (f1b9d72) 95.00%. Report is 63 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #317 +/- ## =========================================== - Coverage 95.97% 95.00% -0.98% =========================================== Files 10 11 +1 Lines 695 760 +65 Branches 145 155 +10 =========================================== + Hits 667 722 +55 - Misses 16 21 +5 - Partials 12 17 +5 ``` | [Flag](https://app.codecov.io/gh/DontShaveTheYak/cloud-radar/pull/317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/DontShaveTheYak/cloud-radar/pull/317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak) | `95.00% <100.00%> (-0.98%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DontShaveTheYak#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhutchison commented 7 months ago

@shadycuz would you be able to review this & take a look at what license compliance issues it is failing on? I don't have access to see what it is failing on.

shadycuz commented 7 months ago

@dhutchison we can merge with this failing check. I just need to fix the MR labels.

dhutchison commented 7 months ago

Ah, sorry - didn't notice it had skipped that check

shadycuz commented 7 months ago

It shouldn't have slipped the label check, I will look into it some other time. But you are all good for merging when you are ready.

dhutchison commented 7 months ago

@shadycuz I've added the labels and now all the checks are passing. No idea why that fixed the license issues but that is a problem for another day.

It doesn't looks like I've got permissions to merge this - do you think I should? If not, can you merge?