Optional Support for JSON Array (replacement for pr #20)

DonutEspresso / big-json

A stream based implementation of JSON.parse and JSON.stringify for big POJOs

MIT License

114 stars 9 forks source link

Optional Support for JSON Array (replacement for pr #20) #22

Closed MoritzLoewenstein closed 2 years ago

MoritzLoewenstein commented 3 years ago

Not much to say, very similar pr to #20, just added the option isRootArray to createParseStream and parse. Would be sick if we can get this merged :)

coveralls commented 3 years ago

Coverage decreased (-2.4%) to 96.053% when pulling 81bfc17ab1251657b3a375b3793313a4267c1f28 on MoritzLoewenstein:feat/array into 7b5d15d8ab4c1c15e8cc55b390c1bed3441db26c on DonutEspresso:master.

lgodard commented 2 years ago

Hi Is there a plan to merge this soon ?

IgorBelyayev commented 2 years ago

DonutEspresso commented 2 years ago

Apologies for the year long delay. 😅 I've rolled this up into #27, which builds upon both @MichaelHirn as well as @MoritzLoewenstein 's work. Please take a look and let me know if that would satisfy y'alls use cases. Can have it released in next few days if so.

DonutEspresso commented 2 years ago

Merged in #27. Released as 3.2.0.