DonutReport / donut

Sweet reports for the icing over your automated tests
http://donutreport.github.io/donut
MIT License
37 stars 21 forks source link

Explicit error handling #24

Closed Roland82 closed 7 years ago

Roland82 commented 7 years ago

Due to the use of options for indicating failure, the messaging that comes back to the user about why failures happen is incorrect.

The test case was a JSON file that was unparseable and the reporter stated that there were not cucumber report files to parse.

I am changing errors to be represented by scala.Either so that we can pull back the exact failure at any point in the process of generating a report.

I also discovered that Descriptions in the JSON reports can actually be skipped in generation. It is perfectly valid (cucumberjs does this) to have a feature file with no feature description so this is now being changed to an option.

amitsha256 commented 7 years ago

@Roland82 Hi Roland, after some major changes merged by me into the master branch, we started getting a lot of conflicts on your pull request. I've resolved all those. I'd like you to have a look.

The major change is that donut can publish nunit results along with the specflow results. JUnit and other non-cuke results will be included in the future.

In terms of usage, you'd need to change the format of the source directory parameter value to: -s cucumber:/my/path/cucumber-reports . Readme md will be updated once we release the next version. We can merge this PR once you've seen the updates.