search

DonutWare / Fladder

Fladder - A Simple Jellyfin Frontend
https://donutware.github.io/Fladder/
GNU General Public License v3.0
157 stars 6 forks source link

Add libmpv-dev to Linux workflow to fix compilation #16

Closed bazzadazza72 closed 2 days ago

bazzadazza72 commented 3 days ago

Hi there,

I managed to boil down the compilation issues to only Android and iOS, the former returning the error Cannot use @TaskAction annotation on method IncrementalTask.taskAction$gradle_core() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method. (the Kotlin version was also out of date, spewing dependency errors into the run log, that has since been fixed, I hope), and the latter returning the No Team Found in Archive error during the IPA export. The main build workflow has been deleted and replaced with separate workflows for compiling on desktop, mobile and GitHub Pages.

Feel free to test out my changes and if you have any issues, let me know. If you still want to collate the GH actions into a single file, I'd be happy to do it once the Android and iOS compilation issues are fixed.

Sorry for the amount of commits and the long rant. I was doing some experimenting, and there were some things that worked and some that didn't. This is my first foray into app development and there were some spots where I didn't know what I was doing.

bazzadazza72 commented 2 days ago

The only issue I encountered during the Android build was the error I mentioned in my first comment, other than the out-of-date Kotlin version.

I was performing my builds in a fork I created, without any secrets or environment variables, so that very well could be my issue.

I'll fix the Linux deployment, and if there's anything else you want me to change, I'm all ears.

bazzadazza72 commented 2 days ago

Sorry 'bout that, I definitely did not mean to close this PR.

Anywho, I've added libmpv-dev as a dependency to the Linux build, again, if there's anything else you need done, I'm all ears.

PartyDonut commented 2 days ago

Thanks for the help, for things to pick-up you can always try picking up one of the issues or features (not sure how experienced you are?)

Otherwise testing out the app and reporting bugs always helps.

Edit: probably also best to open a discussion if you want to implement a feature you're not sure about or need more info on.