search

DonutWare / Fladder

Fladder - A Simple Jellyfin Frontend
https://donutware.github.io/Fladder/
GNU General Public License v3.0
157 stars 6 forks source link

💡 [REQUEST] - Add IPA file to downloads #21

Closed krinkuto11 closed 1 day ago

krinkuto11 commented 2 days ago

Start Date

No response

Implementation PR

No response

Reference Issues

No response

Summary

Title is self descriptive, add an IPA workflow so it is available for download with each release.

Basic Example

This medium page describes a way to accomplish this

Drawbacks

None as far I am concerned.

Unresolved questions

No response

bazzadazza72 commented 1 day ago

We're in the process of doing that. Currently, the action is failing to package the IPA, complaining with a No Team Found in Archive error. I haven't got a macOS environment to attempt a build, but if you have some experience with iOS, any contribution is appreciated.

krinkuto11 commented 1 day ago

That's weird, I forked the develop branch and ran the action (for version 0.2.4), which resulted in a succesful IPA being generated but failed at doing so with Android APK and Linux. Anyways, I do own a Mac so I will try to look at it.

bazzadazza72 commented 1 day ago

Thanks a lot. I was compiling my builds on my fork too, so I figured it was due to not having any secrets or environment variables set.

resulted in a succesful IPA being generated but failed at doing so with Android APK and Linux.

Out of curiosity, did you try doing a run on your own fork, with the latest workflow file? I submitted a PR (specifically #16) which should have fixed Linux building.

Edit: Added quote

krinkuto11 commented 1 day ago

Yes, I ran it in my own fork. I forked the repo 14h ago and it says that it's up to date so I must be using the latest workflow file.

Linux build shows this error Error: This request has been automatically failed because it uses a deprecated version ofactions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Android build shows this one [!] Your project requires a newer version of the Kotlin Gradle plugin. Find the latest version on https://kotlinlang.org/docs/releases.html#release-details, then update the version number of the plugin with id "org.jetbrains.kotlin.android" in the plugins block of /home/runner/work/Fladder/Fladder/android/settings.gradle. Alternatively (if your project was created before Flutter 3.19), update /home/runner/work/Fladder/Fladder/android/build.gradle ext.kotlin_version = '<latest-version>'

bazzadazza72 commented 1 day ago

Just submitted a PR to fix the Linux issue, there was some confusion when I was syncing my fork and the update was reverted (#24). I'll get a PR set up to update the Gradle plugin when I've got time.

Thanks for your help, we're getting there!

PartyDonut commented 1 day ago

Hey all, sorry for the late response. Yes ipa should work now I just had not gotten around yet to uploading the artifacts. I will test run the linux build as well, so all builds should be working.

PartyDonut commented 1 day ago

Version 0.2.5-alpha has all builds included in the assets tab.

p0358 commented 1 day ago

it works 👍 (sideloaded with TrollStore)

native play works too nicely with ASS subtitles, the only two bugs I noticed is:

PartyDonut commented 1 day ago

Thanks for reporting back thats great to hear 👍🏼.

Can you create issues for those bugs?

p0358 commented 1 day ago

Opened in #26 #27