Move more abstract tethering logic?

Doodle3D / connman-api

Connman (Opensource connection manager) client

MIT License

9 stars 10 forks source link

Move more abstract tethering logic? #2

Closed peteruithoven closed 9 years ago

peteruithoven commented 9 years ago

We added enableTethering, disableTethering to Technology, isn't this wifi specific logic? https://github.com/Doodle3D/jsdx-connman/commit/b4c7cc5fc68e4627270d7848878c44d46efbef59

peteruithoven commented 9 years ago

Maybe it's better to keep jsdx-connman limited to the Connman api, which doesn't specify these methods. Then we can include them in a more abstract wifi specific module (connman-wifi?) that uses jsdx-connman.

peteruithoven commented 9 years ago

Understanding the Connman API better I think this convenience method makes sense.