search

Doodle3D / doodle3d-firmware

The API of the Doodle3D WiFi box. This can for example talk to print3d, save settings, update the firmware etc.
www.doodle3d.com
GNU General Public License v2.0
13 stars 9 forks source link

added ultimaker2go startcode end endcode #64

Closed companje closed 8 years ago

companje commented 8 years ago

I updated src/conf_defaults.lua to add startcode and endcode to display status info on the Ultimaker 2go's screen: 'Doodle3D heat up', 'Doodle3D printing' and 'Doodle3D done'.

@peteruithoven I'm not sure how to contribute my changes. May be I should have forked the develop branch? Or is for a minor change like this creating a pull request on the master branch the way to go?

peteruithoven commented 8 years ago

Nice improvement. Out of curiosity, why would this only work for the 2go? Wouldn't this work on Ultimaker2's in general?

This wouldn't really constitute a hot fix, so I would definitely like to keep this in the develop branch.

companje commented 8 years ago

Yes, I think we can just as easily add the M1000x commands to the Ultimaker 2 start and end code. Then we don't have to add the new profile I suggested in this pull request. I will cancel the pull request and create a new one on the develop branch.