search

Doom-Utils / deutex

WAD composer for Doom, Heretic, Hexen, and Strife
Other
61 stars 17 forks source link

Silence warn_unused_result #34

Closed Voros2 closed 7 years ago

Voros2 commented 7 years ago

sound.c: In function ‘SNDloadWaveFile’: sound.c:114:10: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]

chungy commented 7 years ago

Can you please maintain consistent styling with the rest of the code? Almost every text editor should do it automatically for you.

Voros2 commented 7 years ago

So, no {} brackets?

chungy commented 7 years ago

Those are fine. I'm talking about the indentation specifically. (and more minorly, a space between if and the testing expression)

chungy commented 7 years ago

Thanks. Can you amend+rebase instead?

Voros2 commented 7 years ago

May I ask why? I never had to use amend or rebase before, so I'm a bit in the dark about what they're useful for and how to use them safely. But I'll do it if that's the case.

chungy commented 7 years ago

So that the commit history may be clean. It should always represent logical changes and fluff like "code consistency" just clutters it (granted, it's necessary sometimes, but here it is not).

I'll just squash this to merge, but please learn to use git a bit more precisely :)