search

Doom-Utils / deutex

WAD composer for Doom, Heretic, Hexen, and Strife
Other
61 stars 17 forks source link

The lump repeat marker is a mis-feature and should be removed #61

Open andwj opened 6 years ago

andwj commented 6 years ago

Most sections in a wadinfo.txt file support a * at the end of an entry, and it means the current entry will simply be a copy of the previous one, using the same offset and length in the output wad file. Seems the idea is to save space if you have a resource that is repeated.

The main exception is the [LEVELS] section, which currently ignores the repeat marker.

I have quite a lot of wadinfo files on my computer (over 100), including from most of the IWADS, and only two of them contain this repeat marker: the Heretic iwad and the Hexen iwad, used three times in each one, and all of them are zero-length lumps.

So I think this is actually a mis-feature with very low utility, and Deutex would be better without it. The code to support it really hampers understanding of the composition code in compose.c. It also makes it harder to add support for new sections in Deutex, e.g. I haven't coded support for it in the TX_START stuff yet.

fragglet commented 5 years ago

Interesting, I didn't know that deutex had this feature. Note that you can use wadptr to get the same result automatically without any special configuration.