search

Doom-Utils / deutex

WAD composer for Doom, Heretic, Hexen, and Strife
Other
61 stars 17 forks source link

Allow users to control whether or not to build the manpages #63

Closed vilhelmgray closed 5 years ago

vilhelmgray commented 5 years ago

Implement the "--enable-man" option to give users control of whether to build the manpages or not.

chungy commented 5 years ago

Hmm, the configure script already has code to check whether a2x exists and builds the manpage conditionally on that. I'm not really sure why it would be desirable to disable the manpage generation, it does not take very long to build. Do you mind enlightening me on the use case?

On that note too, it should always be built by default, a --disable option would be better than --enable, if accepted.

vilhelmgray commented 5 years ago

Some systems have policies of manpage generation control. In particular, I'm developing an ebuild for Gentoo Linux where users typically have control of whether manpages and documentation files are generated: https://github.com/gentoo/gentoo/pull/12262

I'll update this to build the manpages by default so that the existing behavior isn't affected.

vilhelmgray commented 5 years ago

I've updated the patch to always build by default -- users are notified that --disable-man can be used to disable the manpage build.

chungy commented 5 years ago

Seems fair enough. The comment in the gentoo thread is right that I don't care that much, but the patch is small enough. Thanks.