search

Doom9527 / aristotle-webservice

👑 A web servide enables you to create knowledge graph.
https://aristotle-ws.com
16 stars 0 forks source link

Consolidating `nodeServiceImpl` and `nodeMapperImpl` #62

Open QubitPi opened 2 weeks ago

QubitPi commented 2 weeks ago

It is going to be a big risk to have 2 similar service layers when projects gets bigger and more complicated. We must make them one.

@Doom9527 Let's discuss it in regular meeting

Doom9527 commented 2 weeks ago

In fact, nodeMapperImpl is part of the data access layer, and it belongs to the same layer as nodeRepository.

QubitPi commented 1 week ago

But having the two with the same method of getNodeByUuid is still confusing. This is a code smell and we should definitely get rid of one of them