search

DoomPatrol / applause-extension

Give all of your favorite writers on Medium the applause they deserve.
0 stars 0 forks source link

Doesn't Work #1

Open chrisspiegl opened 6 years ago

chrisspiegl commented 6 years ago

Hey Austin,

I just installed the Chrome Extension but nothing seems to be happening on Medium. No extra buttons, no nothing. It also does not show any claps that I have given.

Is this known? Is it on my part? What's going on here?

I'd like to help make this work if it's something I can do.

Cheers,

Chris

Venryx commented 5 years ago

Same. Doesn't seem to do anything. Might look at the source code later and see how it was intended to work.

Venryx commented 5 years ago

Okay, it appears it's supposed to add a multi-clap button in-page like expected: https://github.com/DoomPatrol/applause-extension/blob/master/src/inject/inject.js

Must have just broken with website updates. Still have my concerns about the permissions requested, ie. strongly urge the creator to give an explanation of why that is needed.

DoomPatrol commented 5 years ago

Hey thanks for checking this out! I honestly built this as a fun little side project a while ago and haven't updated it in a bit. I was new to extensions at the time and used a boilerplate setup, hence the stock permission requests.

If I have some time I can go through and edit them as I think you're right and I don't need those permissions. I don't have time at the moment to fix the extension though, but may in a little while. I would imagine that Medium has updated their layout and it probably broke something.

Venryx commented 5 years ago

I figured it was something like that. I also am pretty new to Chrome extensions so only have one published myself (one for Quora), and occasionally it breaks when they update the site, so I know what it's like.

Regarding the permissions, it's odd that the boilerplate setup would start with requesting a permission like that, but that does explain it. :) Maybe I'll raise an issue there later asking if they can rework the boilerplate to not require that, as it can be concerning to users of new extensions that are based on it.

Anyway, thanks for responding.