search

Dooskington / GameLad

:tv: An (almost) fully featured Game Boy emulator.
MIT License
469 stars 33 forks source link

added a few tests for high/low bytes for homework #106

Closed rmcrosley closed 6 years ago

rmcrosley commented 6 years ago

I needed to add something to an open source project for an assignment. Thank you for allowing me to contribute

Dooskington commented 6 years ago

Thanks for the PR, but I'm not going to merge it.

The additional test case is unnecessary, and in fact I think you broke the low byte test. Instead of calling GetLowByte() inside the test, you call GetLowByte_Test(), which is just the test itself.

Best of luck with your assignment.