Turns out that --inplace was parsed wrong and as soon as --inplace
is passed (and it is always passed) it essentially actually meant
--inplace True. And when --inplace True is passed, then the exit
code will be 0 and thus the action always is successful.
Observation
I observed that the following action always passes - even after I added bad indentation on purpose.
For example, the following call always returns an exit code of 0:
The bug
Turns out that
--inplace
was parsed wrong and as soon as--inplace
is passed (and it is always passed) it essentially actually meant--inplace True
. And when--inplace True
is passed, then the exit code will be 0 and thus the action always is successful.See https://stackoverflow.com/questions/15008758/parsing-boolean-values-with-argparse for more information on parsing booleans.
Running the above Docker command with my fix actually returns an exit code of 1 and thus the actions also fails as expected.
Fixes #18. Fixes #19