search

DoozyX / clang-format-lint-action

This action checks if the source code matches the .clang-format file.
MIT License
129 stars 46 forks source link

Support for clang-format 12.0.1 #35

Closed bernhardmgruber closed 2 years ago

bernhardmgruber commented 2 years ago

Thank you for providing this github action! The latest patch release 12.0.1 for clang-format unfortunately breaks formatting compared to clang-format 12.0.0. Could you please also provide the action for clang-format verison 12.0.1? Thank you!

bernhardmgruber commented 2 years ago

I started preparing a PR , but then I wondered, whether clangFormatVersion: 12 should actually choose 12.0.0 or 12.0.1. It's a patch release so my first thought is to just replace the existing clang-format12 binary. But this could break many users, since 12.0.1 formats differently than 12.0.0 in some edge cases. What is your opinion on this?

DoozyX commented 2 years ago

Hello, sorry for the inactivity, was busy with other work. In the previous versions the major version was the updated one if it existed. I think for now replacing it with the updated version should be ok. If they don't update the clang-format action they will still use the 12.0.0 so it won't break anything, in the release notes it can show that the clang-format version was updated if they update the action version. I am thinking of having the major version pointing to the latest if available, and if needed for minor version we can add additional clang-format executables with exact version ex clangFormatVersion: 12 and clangFormatVersion: 12.0.1 will be use clang-format12.0.1 while clangFormatVersion: 12.0.0 will be the clang-format12.0.0 executable