search

DopplerHQ / kubernetes-operator

Apache License 2.0
45 stars 18 forks source link

v0.0.1 Implementation #4

Closed nmanoogian closed 3 years ago

nmanoogian commented 3 years ago

OK, there's one more thing that I need to debug relating to passing the version to the docker image during the Github Actions build. Other than that, the code should be ready for your review!

I haven't decided whether I want to squash these commits or not. Recommendations?

nmanoogian commented 3 years ago

Thanks for the feedback guys! I incorporated it into these changes: https://github.com/DopplerHQ/kubernetes-operator/compare/42246f6..c08de634ed19a30250005ac6af81f45e8fc114c9

Part of these changes also included some adjustments on what specifically we're storing in the DopplerSecret. Instead of storing the service token directly, it's a reference to another Kubernetes secret that contains the token. This allows the user to take advantage of Kubernetes' encryption at rest to secure their token. I was worried that it would add a lot of complexity but it actually makes setup a bit easier 👍

nmanoogian commented 3 years ago

@ryan-blunden All of my changes are in! If you have a sec to work through the README in a dummy cluster, I'd love to get your feedback on the experience.