search

DopplerHQ / kubernetes-operator

Apache License 2.0
44 stars 18 forks source link

Add support for custom managed secret types #47

Closed nmanoogian closed 1 year ago

nmanoogian commented 1 year ago

This PR adds custom Kubernetes secret types to the operator. The README and docs changes describe the use cases and behavior changes.

Closes ENG-6130

emmeowzing commented 1 year ago

Wow at first glance over the changes and doc, this is an amazing change/update. May do exactly what I needed

nmanoogian commented 1 year ago

Looks good to me. I just have some minor nitpicks, but mergeable as is.

Awesome! Thanks for calling those out. I'll make the changes.

I don't see any tests for this change, how do we test changes to the operator?

Great question -- our tests for the operator are definitely lacking and most of my testing for this change has been manual. I'd love to pick your brain on ways that we could add automated tests for this functionality!