search

DopplerHQ / python-sdk

MIT License
7 stars 3 forks source link

Make dependencies less strict #9

Closed alex-linx closed 10 months ago

alex-linx commented 11 months ago

At the moment the dependencies for this project are set to a very specific version

dependencies = [
    "requests==2.31.0",
    "http-exceptions==0.2.10",
    "pytest==7.1.2",
    "responses==0.21.0",
]

this makes it difficult to install into an existing environment with other versions fot hose packages installed.

Please consider making those dependencies less strict

Piccirello commented 11 months ago

Thanks for the suggestion. I've logged a feature request with our SDK generation library (LibLab).

maurczz commented 11 months ago

I believe that pytest should also not be a dependency of this SDK. It's a dev-time dependency, not a "runtime" dependency.

And I agree with @alex-linx that as a user of this SDK, seeing the pinned dependencies is really bad. You can pin dependencies for your internal dev workflow, sure, but you should not force users of the package to use only super-specific versions of dependencies unless strictly necessary.

Piccirello commented 10 months ago

v1.2.1 has been released and no longer hardcodes these dependency versions.