search

DopplerHQ / terraform-provider-doppler

Apache License 2.0
23 stars 9 forks source link

ENHANCEMENT: Expose `delete_from_target` for supported by provider syncs #90

Closed ViacheslavKudinov closed 1 month ago

ViacheslavKudinov commented 5 months ago

Currently when termination of Terraform resources happens, secrets and "resources" will still remain on the target's side.

As it is supported by REST API it will be great to expose for "users" of provider to be able to set delete_from_target when they decide it is safe to have this behavior. Moreover it is the option on Doppler UI to keep or delete secrets on the target.

So, it will be great to get option to delete secrets of target. Maybe, can be set false by default for the "safety".

ViacheslavKudinov commented 5 months ago

In some sense related to https://github.com/DopplerHQ/terraform-provider-doppler/issues/65 as well

nmanoogian commented 5 months ago

Thanks for the recommendation, @ViacheslavKudinov! Working on this now

ViacheslavKudinov commented 1 month ago

Hi, i think it was addressed by this PR https://github.com/DopplerHQ/terraform-provider-doppler/pull/93 and is there sinse v1.9.0

nmanoogian commented 1 month ago

Right you are! I must have forgotten to add the "Closes" magic word to that PR. Thanks!