DopplerShift13 / DopplerShift

Doppler Shift, a /tg/station Fork for SS13
https://dopplershift13.com/
GNU Affero General Public License v3.0
7 stars 22 forks source link

Fixes a runtime issue involving character loading and languages. #175

Closed 00-Steven closed 6 days ago

00-Steven commented 6 days ago

About The Pull Request

hi yeah i was reading the repo and testing master while waiting for the application and this was getting in the way so-

Anyhow, it seems the occupation and language menus were breaking due to languages runtiming at this line:

https://github.com/DopplerShift13/DopplerShift/blob/c4f78bcac0ef990a240bff1f38fbb62fba9d4c98/modular_doppler/languages/code/language%20menu/client_languages.dm#L68

Which was due to preferences.all_quirks being null even though it should never be, which I traced back to us using save_data["languages"] where save_data could be null causing load_character(...) to runtime.

Setting it to save_data?["languages"] parallel to all the other save_data calls there seems to fix it just fine!

yep that's a languages menu 👍

Why It's Good For The Game

Fixes runtimes.

Changelog

:cl: fix: Fixed language, occupation, and quirk menu breaking if there is no existing save data. /:cl: