search

DopplerShift13 / DopplerShift

Doppler Shift, a /tg/station Fork for SS13
https://dopplershift13.com/
GNU Affero General Public License v3.0
7 stars 22 forks source link

[NON-MODULAR] Volume mixer #181

Open W4rd3nn opened 5 days ago

W4rd3nn commented 5 days ago

About The Pull Request

So i made a recent PR that changes some of the announcer sounds. Its a lil too loud 4 some people. Rather than going back, tweaking the sounds, and then sending them for review again, I figure I'll just port this closed PR from TG that allows ppl to set a preference for the volumes of certain sounds. This is that PR. Most of the code is courtesy of sadboysuss's PR: https://github.com/tgstation/tgstation/pull/86932 but I debugged certain parts of it and also added a preference for announcement sounds which is what I wanted in the first place. I also removed the TTS volume part because we dont have that.

Idk how hacky this is and it's certainly not modular so I'd appreciate someone with better knowledge taking a look at it.

image

Why It's Good For The Game

Earz :3

Changelog

:cl:Motho qol: You can now adjust the volume of certain sound types without outright disabling them. /:cl:

W4rd3nn commented 5 days ago

This good for https://github.com/DopplerShift13/DopplerShift/pull/157 metinks :3

W4rd3nn commented 4 days ago

ill sign off on these prob tomorrow. busy 2day :3