Dorako / pf2e-dorako-ui

MIT License
18 stars 17 forks source link

[BUG] Sheet theme not applying #335

Closed Kronos25 closed 2 weeks ago

Kronos25 commented 2 weeks ago

I know I just reported a bug and closed it as solved, but I noticed a new one a couple of moments after the new update (UI v. 3.5.12 // UI v. 1.50)

When selecting a theme for the character sheet, it doesn't seem to apply and defaults to the light theme image

Dorako commented 2 weeks ago

I can't reproduce this. CleanShot 2024-08-30 at 03 23 13@2x Are you using the starfinder module? Are you sure a theme is applied at all, or is it just the stock foundry look? (Check the titlebar)

Kronos25 commented 2 weeks ago

I'm using the Pathfinder module/system image

I'm almost sure it's applying the theme (or supposedly to), I've tried changing it to other combinations, but now that you mentioned related to the title bar, it seems somewhat related to the stock foundry look. Not sure what is going on image image

It's not applying the change color for the sheets too (it's always red)

EDIT: Created a new world, enabled only dorako UI+UX, tried to apply changes and it's also the same there: image

Dorako commented 2 weeks ago

Yeah so what I'm seeing is that no theme is getting applied for that sheet, which is typically because it's been excluded, or because the theme system is crashing. (Check for red console logs). I've put out an update, see if that fixes it for you.

Ethmaker commented 2 weeks ago

I am getting the same issue with the update. Here's the console error that is showing up for me: image

Kronos25 commented 2 weeks ago

It seems to be working for me now, thanks :)
I'll leave the topic open for now to make sure it's also solved for @Ethmaker and others image

Thank you!

Ethmaker commented 2 weeks ago

After updating modules again and reloading the world, the issue seems fixed and themes are properly working again.

8bitjunkie commented 6 days ago

image Here is the error; I have a similar problem - all updated system and Dorako mods.

Dorako commented 6 days ago

I see the issue, should be fixed for next release.