search

Dorako / pf2e-dorako-ui

MIT License
18 stars 18 forks source link

[BUG] Setting Interface Theme to "No Theme" still change sidebar #339

Closed farling42 closed 1 month ago

farling42 commented 1 month ago

With the Interface Theme set to "No Theme".

The element inspector shows that a style is still being applied to the sidebar.

[data-dorako-ui-scope=sidebar] .tab:not([data-tab=chat])

My UI settings: image

Dorako commented 1 month ago

Yeah, Dorako UI needs to modify the sidebar for chat message themes to work, so this is expected.

farling42 commented 1 month ago

But the CSS I quoted specifically excludes the chat tab, and it is affecting all the other tabs.

I primarily noticed the problem on the Game Settings tab where there is no decoration on the buttons at all.

Dorako commented 1 month ago

I see what you mean, there's a couple of styles in _sidebar that is using [data-dorako-ui-scope=sidebar] where they should be using [data-chat-interface-theme]. Fixed for next release.