Dorako / pf2e-dorako-ui

MIT License
18 stars 17 forks source link

Player Color for PC Actor in PF2E: All Same Color #344

Open Armandeus66 opened 1 week ago

Armandeus66 commented 1 week ago

Thank you for considering this! It's awesome!

All of my players (with different colors) have actor sheets with the color from only one of the players, but I appreciate that this is a work in progress.

Dorako commented 1 week ago

Yeah, looks like I'll need a better way of determining who's the "real owner" of an actor

Armandeus66 commented 1 week ago

Thanks for updating and working on this, but I still seem to have the same issue.

Dorako commented 1 week ago

I have done nothing to change it, so that checks out. I'll be sure to write it in the patch notes.

Armandeus66 commented 1 week ago

Sorry, I saw an update, and jumped to conclusions. My bad.

Dorako commented 1 week ago

Is it fixed now in 3.7.4?

Armandeus66 commented 1 week ago

Thanks! It works! Awesome!

Armandeus66 commented 5 days ago

With the latest update, now all the actors use one player's color and not the other. Both players have observer status on each others' sheets.

If a player higher on the permission list for the actor is set to observer or limited, the actor changes to that player color, even if another actor lower down is the owner.

Dorako commented 4 days ago

So it worked for you in 3.7.4 but not in 3.7.5? The only thing I did related to sheet colors, was introducing an early termination check for the case where there's no actor (which obviously should never be the case for character sheets).

Armandeus66 commented 3 days ago

I think it worked in 3.7.4. I remember checking and being impressed that it did. Maybe I did something wrong. You can reproduce my issue by creating 4 PC actors and 2 players with different colors. Give Player A owner status on 2 characters and Player B 2 as well. Give each player observer permission on the other's 2 actors. "Player A" should come before "Player B" in the permission list, and if the same issue appears, Player B's owned actors should be Player A's color. Thanks for working on this!