Doraku / DefaultDocumentation

Create a simple markdown documentation from the Visual Studio xml one.
MIT No Attribution
157 stars 26 forks source link

VB Project Issue #106

Closed bwood4 closed 2 years ago

bwood4 commented 2 years ago

VB projects don't have the intermediate path prepended to the DocumentationFile property, which causes the DefaultDocumentation task to break because it can't find the file (see this issue). Altering the DefaultDocumentation target to the following would fix it:

<_DefaultDocumentationDocumentationFile Condition="'$(MSBuildProjectExtension)' == '.vbproj'">$([System.IO.Path]::GetFullPath($(IntermediateOutputPath)$(DocumentationFile)))</_DefaultDocumentationDocumentationFile>
<_DefaultDocumentationDocumentationFile Condition="'$(MSBuildProjectExtension)' != '.vbproj'">$([System.IO.Path]::GetFullPath($(DocumentationFile)))</_DefaultDocumentationDocumentationFile>
Doraku commented 2 years ago

Sure I never intended for DefaultDocumentation to be used by vbproj or fsproj as it produces code snippet in c# only but with plugins people could change that. If all it requires to work with vbproj is this simple change I will gladly take it :) thanks for the heads-up.