Doraku / DefaultDocumentation

Create a simple markdown documentation from the Visual Studio xml one.
MIT No Attribution
157 stars 26 forks source link

#40 - add support for source & region in the code XML element #41

Closed basvanderlaken closed 3 years ago

Doraku commented 3 years ago

Impressive work, I'll try to take the time to review it properly. The fact that you had to upgrade to net5 seems strange but at the same times I was wondering if there was even a point in keeping net framework compatibility (and even netcore3.1) since most users would have net5 installed anyway. Losing all but net5 would probably enable an easy way to pack DefaultDocumentation as a global dotnet tool for those who wants it too. You even added tests, now I just feel ashamed for never coding any ^^"

basvanderlaken commented 3 years ago

Thanks, good to hear you appreciate it! Indeed net4* and netcore3.1 framework compatibility is quickly becoming less and less of an issue. Especially when building & running in containers. If it is ok with you, I will probably open some other issues & pull request for the following additional functionality:

Doraku commented 3 years ago

Just a quick note, I will do a quick refactoring to remove the multi targets to expose DefaultDocumentation both as a msbuild task and a dotnet tool so things will move around (most of the code will ends up in a DefaultDocumentation.Common lib). Hopefully I will be done with it this week end. Thanks again for this feature :)