search

Doraku / DefaultDocumentation

Create a simple markdown documentation from the Visual Studio xml one.
MIT No Attribution
157 stars 26 forks source link

Command line args parser missing separator attribute #73

Closed cumiller closed 3 years ago

cumiller commented 3 years ago

When parsing command line arguments, the parser fails to separate the multiple externLinks separated by "|".

Observed result: The entire -e argument value is stored in the first element of "externlinksFilePaths". No split is performed.

Expected result: The multiple extern links would be split based on the "|" and externLinksFilePaths would have separate elements for each path in the argument string. "A|B|C" would produce separate items in externLinksFilePaths.

Fix: SettingArgs.cs 

[Option('e', nameof(ExternLinksFilePaths), Separator = '|', Required = false, HelpText = "Links files to use for external documentation")]
public IEnumerable<string> ExternLinksFilePaths { get; set; }
Doraku commented 3 years ago

You are right, it's probably better to have parameters parsed the same way in both msbuild task and dotnet tool. Will do :)