search

DorisAmoakohene / Codes-and-Test-for-my-paper

0 stars 0 forks source link

Performance Testing #3

Closed DorisAmoakohene closed 3 months ago

DorisAmoakohene commented 3 months ago

@tdhock

See graphs to show for performance testing for your review

atime list 5427

atime list 4200

tdhock commented 3 months ago

please change slow to Slow (capital S)

please use colors from atime_pkg, https://github.com/DorisAmoakohene/Codes-and-Test-for-my-paper/issues/4#issuecomment-2258077652

tdhock commented 3 months ago

please remove x axis ticks larger than data range (1e9, 1e5)

please clarify x axis title -- what is data size? (rows, columns, etc?)

DorisAmoakohene commented 3 months ago

atime list 4200 atime list 5427

tdhock commented 3 months ago

please increase the number of grid points 10^seq(1,7,by=0.25) instead of by=1 please remove 1e8 tick which is outside of data range

DorisAmoakohene commented 3 months ago

when I remove tick 1e8 it makes the text size of the fast and slow small

tdhock commented 3 months ago

I understand that you have reduced the range of the x axis from 1e8 and that makes the text size of the direct labels too small. I did not suggest to reduce the range. Keep the same range, and remove the 1e8 tick, by using scale_x_log10(limits=c(1e1,1e8), breaks=10^seq(1, 7)) etc