search

DorisAmoakohene / Codes-and-Test-for-my-paper

0 stars 0 forks source link

reference best #5

Open DorisAmoakohene opened 4 weeks ago

DorisAmoakohene commented 4 weeks ago

Hi @tdhock if you say "please remove facet_grid and instead use a Y axis" do you mean like the below best list R

tdhock commented 4 weeks ago

yes that is better but now please remove aes(color) in geom_ribbon and please use direct labels instead of legend also remove ".replacement" from expression names

DorisAmoakohene commented 4 weeks ago

best list R

tdhock commented 4 weeks ago

hi Doris that is better, but please remove tick marks outside the range of the data (10000) also it may be better to increase N, so that both go up to some time limit, say 0.1 or 1 second? also you may want to re-run the timings because the curves are somewhat choppy, which is unusual. Typically I would expect them to be a bit more smooth, unless the data are random? and even then you should be using set.seed to control the randomness and reduce the variability between N values.

DorisAmoakohene commented 4 weeks ago

best list R

tdhock commented 4 weeks ago

looks good!

tdhock commented 4 weeks ago

although "linear" and "constant" may be confusing names because the reader would think about linear time and constant time, but actually "constant" label is linear time, and "linear" label is quadratic time, so maybe think about changing the labels, or using a different example, where there is no such confusion?

DorisAmoakohene commented 4 weeks ago

I will change the labels then. Thanks for the clarity