search

DorkixAzIgazi / NetheriteCompass

MIT License
3 stars 0 forks source link

Not working #5

Closed Just1C3-2 closed 3 months ago

Just1C3-2 commented 7 months ago

I'm using the latest version but it doesn't work. The compass is only get lock when ancient debris is exposed. I also got some optimization mods as well so I'm not sure if it's a bug in the mod itself or if it's just incompatible with other mods

DorkixAzIgazi commented 7 months ago

Can you give me more details, like the minecraft version and mod versions you are using? Optimazition mod could be a problem if they prevent nearby chunks from loading. Also please make sure you are familiar with how the locking mechanic works, you can read all you need in the README file.

Just1C3-2 commented 7 months ago

farbic 1.20.1 netherrite compass 1.0.1 about optimzaition mod im using c^2m lithium sodium mordenfix starlight indium that is all

DorkixAzIgazi commented 7 months ago

farbic 1.20.1 netherrite compass 1.0.1 about optimzaition mod im using c^2m lithium sodium mordenfix starlight indium that is all

image I've tried this with a fresh minecraft install, with these mod versions, created a new default world in creative, went to the nether and started using the compass, worked just fine for me, on level 15 it pointed to the nearest Ancient Debris. I found 5 one after the other which were not exposed.

Note, I didn't change any setting for the mods. If you share your settings for the mods and/or provide a world seed with location or a world download, where you think the mod doesn't work, I could take another look. I didn't find any compatibility issues this time.

I might update the mod to 1.20.4, if I have the time.

Just1C3-2 commented 7 months ago

I created another world in creative mode,and guess what? it worked. After that I experimented again on the previous world which it didn't work, but idk why it still didn't work??? Now I have absolutely no freaking idea how this happens. should this only work in new world before the mod was added?

Just1C3-2 commented 7 months ago

and i think i found why,i think im a totally dumb. when a chunk is generated before this mod added,this compass didnt work. and this is because what u said in readme:The mod will turn the Ancient Debris block into a Block entity (like a chest or furnace). Altought this sounds strange, it does not affect its behaviour in any way, but helps the mod perform much better as it only needs to look at block entities in the chunk not all blocks. Minecraft's code already handles block entities differently than blocks, the mod only filters for a certain type (Ancient Debris) and finds the clossest one to the player. i think that is it.sorry for wasting your time

Just1C3-2 commented 7 months ago

there is some screen shots 2024-03-25_13 54 20 2024-03-25_13 54 23 2024-03-25_13 54 31 2024-03-25_13 54 35 and you could see in the last picture,once i could touch(or reach)that block,the compass instantly get locked on it

DorkixAzIgazi commented 7 months ago

and i think i found why,i think im a totally dumb. when a chunk is generated before this mod added,this compass didnt work. and this is because what u said in readme:The mod will turn the Ancient Debris block into a Block entity (like a chest or furnace). Altought this sounds strange, it does not affect its behaviour in any way, but helps the mod perform much better as it only needs to look at block entities in the chunk not all blocks. Minecraft's code already handles block entities differently than blocks, the mod only filters for a certain type (Ancient Debris) and finds the clossest one to the player. i think that is it.sorry for wasting your time

This is instresting this could be a problem. I could see Ancient Debris in old chunks not turning into block entities, as when a save is loaded they are saved as normal blocks, I think? I am not sure how this works when the world is saved or loaded. I'll look into in a few days.

DorkixAzIgazi commented 7 months ago

I can confirm that the above is the case. Ancient Debris blocks generated in the world before the mod was added are not detected by compass. This should not be the case, you should be able to just add the mod and use it with you existing worlds.

I do not know the solution for this, but I'll try to think of something in the following days. Feel free to comment if you can think of anything to fix this.

Thanks for you patience.

DorkixAzIgazi commented 3 months ago

@Just1C3-2 Hi, I finally got around to fix this issues feel free to contact me if you find anything else :D release