Added DisableCulexMusic flag. YouTube likes to flag and demonetize VoDs containing it.

[CaptainDapper]

• Added the rest of the music groups as well, including "no change from the overworld" BattleMusic.CURRENT
• Separated music group ID from can_run flag bits.

I mostly decided to do this one little thing, but if I continue, I'd like to:

• Add a flag for all formations to have shuffled music
• Add a flag for all songs to have a chance to be in one of the 8 groups
• Optionally only replaces the ordinarily unused groups
• (Battle music is limited to 8 different Songs, but they don't have to be the 8 we're used to! See data/bosses.py)
• Add a separate instance of RNG so a cosmetic change such as this (or palette) doesn't affect item placement/race viability.

[DorkmasterFlek]

I'm not sure about this change, specifically the new flag... While I don't have an issue with potentially allowing other songs to be used in the shuffle, I'm not a huge fan of adding more flags to disable specific music tracks because of an external site being dumb. The number of flags is already large and cluttered to begin with, and this could happen with any track in the game. If we add a flag for Culex's music, where does it stop? My feeling is it's not the randomizer's job to account for YouTube's ridiculous content policing.

[pidgezero-one]

I'm not sure about this change, specifically the new flag... While I don't have an issue with potentially allowing other songs to be used in the shuffle, I'm not a huge fan of adding more flags to disable specific music tracks because of an external site being dumb. The number of flags is already large and cluttered to begin with, and this could happen with any track in the game. If we add a flag for Culex's music, where does it stop? My feeling is it's not the randomizer's job to account for YouTube's ridiculous content policing.

I have plans to build a stronger cosmetics interface during the next major release that could have an option to pick and choose which songs you want included in the shuffle. The flag interface is cluttered as it is and will be undergoing a massive overhaul.

[DorkmasterFlek]

I have plans to build a stronger cosmetics interface during the next major release that could have an option to pick and choose which songs you want included in the shuffle. The flag interface is cluttered as it is and will be undergoing a massive overhaul.

Fair enough, a cleaner flag UI would definitely help. If you do have something like this, I agree it makes more sense to make it a general music track selection rather than separate flags for specific tracks to disable.

[CaptainDapper]

That's fair! I was thinking about the messiness when I was working on it, but I figured it would be more worth it for bigger youtubers to desire to play the game and spread its popularity than hold the feature up while overhauling the flags. A little mess now for a medium gain, rather than a large detangling for medium gain.

It doesn't seem like too big of a mess from the user's perspective, although the UI could be a lot nicer. From a flag's perspective, well people endure much worse :P

By no means was this an attempt at a permanent fix for YouTube's bs nor for music selection/cosmetic things. :)

[pidgezero-one]

Just as an update, I've got this basically working in the upcoming version 9.0.0 - this hasn't been forgotten about and cosmetics will be separated from flags entirely, including an option to pick and choose which songs you want in your random song pool. I've gotten most of the front end working this past weekend to go with the backend I wrote about a month ago.

[DorkmasterFlek]

The next patch will be a major rewrite which has a new flag UI for selecting any songs, so this won't be needed there.